IBX-8891: Fixed XML link validation to allow using tel: in links
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vidarl
force-pushed
the
IBX-8891_XML_link_validator_in_rich-text_does_not_allow_to_use_tel_links_schematron
branch
from
d0a170a
to
20ba45e
Compare
glye
approved these changes
Sep 19, 2024
vidarl
changed the title
alongosz
changed the title
tel: in links
Comment on lines
+628
to
+631
| - | ||
| message: "#^Offset 1 does not exist on array\\{0\\?\\: string, 1\\?\\: ''\\|'ezremote\\://', 2\\?\\: string, 3\\?\\: string\\}\\.$#" | ||
| count: 1 | ||
| path: src/lib/eZ/FieldType/RichText/RichTextStorage.php |
There was a problem hiding this comment.
Note: allowing this since this is baseline alignment after an update and fixing this requires some changes that would take significant amount of time (impl + QA)
There was a problem hiding this comment.
yeah, and the same thing was done in 4.6 : ibexa/fieldtype-richtext@560eecf
mikadamczyk
approved these changes
Sep 19, 2024
konradoboza
approved these changes
Sep 23, 2024
tomaszszopinski
approved these changes
Sep 25, 2024
konradoboza
deleted the
IBX-8891_XML_link_validator_in_rich-text_does_not_allow_to_use_tel_links_schematron
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds supports for
tel:linksI synced with Gunnstein and we agree to keep the validation in schematron, but to simplify it, in order to keep the number of checks down as there is a default limit of 9:
The most important think in this case is to ensure the security aspect, not to ensure that the URLs are syntactical correct (ie, we don't need to check for
ezcontent://,ezlocation://,ezremote://orezurl://. We can simply have one rule that check for "starts with ez")You may have a look at #244 for a different approach